Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coincidences download always yield -999 for event zenith, azimuth #272

Open
tomkooij opened this issue May 6, 2019 · 5 comments
Open

Coincidences download always yield -999 for event zenith, azimuth #272

tomkooij opened this issue May 6, 2019 · 5 comments
Assignees

Comments

@tomkooij
Copy link
Member

tomkooij commented May 6, 2019

Reported by @josst:

events in coincidence download always return -999, -999 for reconstructed zen,azi while these values are available in separate event download.

affected line:
https://github.com/HiSPARC/publicdb/blob/master/publicdb/raw_data/views.py#L682

@tomkooij tomkooij self-assigned this May 6, 2019
@153957
Copy link
Member

153957 commented May 6, 2019

Because we do not yet have reconstruction of coincidences in the ESD/processing.

That would be a task to be added here:
https://github.com/HiSPARC/publicdb/blob/master/publicdb/histograms/jobs.py#L303

Just like for events:
https://github.com/HiSPARC/publicdb/blob/master/publicdb/histograms/jobs.py#L265

@153957
Copy link
Member

153957 commented May 6, 2019

See #145

@tomkooij
Copy link
Member Author

tomkooij commented May 6, 2019

In the download the zenith/azimuth is supposed to be the 'event' zenith/azimuth (all other data is 1-to-1 copied from ESD event data). The reconstructed coincidence zenith/azimuth should be another/different field and documented...

Some more work. Priority not high.

@153957
Copy link
Member

153957 commented May 6, 2019

I think one of the main issues with this was the orientation of the ENU plane, as described in that other issue. I think that normally when reconstruction coincidences the reference location/station of the Cluster object used for reconstructions is the origin of the ENU plane. This may need to be made local/center of mass to the current coincidence being examined to prevent an angle offset because of that.

@153957
Copy link
Member

153957 commented May 6, 2019

Ah I see what you mean! ok that is a different issue than I was describing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants