Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split TrainedSupervisedModel into 3 classes (Base, Regressor, Classifier) #446

Open
Aylr opened this issue Nov 18, 2017 · 0 comments
Open
Labels

Comments

@Aylr
Copy link
Contributor

Aylr commented Nov 18, 2017

Background

There is a ton of logic for classification only properties that is making maintenance burdensome. Extract out two new classes TrainedRegressor and TrainedClassifier (or other better names) that inherit from the TrainedSupervisedModel class. This will drastically clean up code, tests and make maintenance easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant