-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interactive Dismiss Animation #65
Comments
It's been on my mind but I'm not certain about it. It's not entirely clear what velocity or progress is needed to ensure a swipe dismisses or cancels, and there's no way to indicate this. Additionally, Apple Mail is also yet to adopt this new style, so I think I'm gonna wait a while to see if people are comfortable with it and it sticks, and implement it if it does. |
Apple Mail does implement an interactive transition, I'm not sure what you meant by 'new style'. In Apple Music, it looks like it doesn't look at velocity and there is just a certain threshold where if you swipe below that it will dismiss if you lift your finger. So yeah there's definitely no consistency there. So if you were to implement it I guess the best bet would be to have configurable progress and velocity thresholds for dismissal. (Or some method in DeckTransitionViewControllerProtocol so each VC can have custom parameters) |
The new style I meant is the one implemented in Music in iOS 11.2 which calculates dismiss/cancel based on velocity and/or progress (and also animates the presenting view alongside the swipe); I presumed that's what you meant since before that Music didn't have an interactive dismiss. Regarding configurable thresholds, I'm very hesitant about adding new customisation points, especially for something that should ideally be standard; it would be chaos if say every app had its own |
I just loaded up an iOS 10 device and I see your point now, this library currently works the same way as iOS 10 Apple Music. And I totally understand your point regarding customization, but the way it is now where it is dismissed the iOS 10 way it is essentially adding another "standard". How about leaving the dismissal as is for now, just making it so that when you're swiping down the background view scales based on percent dragged? |
I have try to make the apple music play bar transition demo by myself and I think that the dismiss animation may not be implemented by the UIPercentDrivenInteractiveTransition. It just looks like interactive. -> my demo https://github.com/Cookiezby/AppleMusicTransition |
@felix-dumit Good Idea! Seems like a nice middle ground @Cookiezby That’s a good project! Sent with GitHawk |
@HarshilShah Thanks, hope the project can give some inspiration :D |
Any plans to support an interactive dismiss animation, similar to how the Apple Music apps currently works?
Thanks for this library!
The text was updated successfully, but these errors were encountered: