Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug report and suggestion on how to fix it. #54

Open
hash2430 opened this issue Sep 16, 2019 · 0 comments
Open

Possible bug report and suggestion on how to fix it. #54

hash2430 opened this issue Sep 16, 2019 · 0 comments

Comments

@hash2430
Copy link

hash2430 commented Sep 16, 2019

I think you need to change utils.get_cossim() line 42
as follows
from
if speaker_num == centroid_num:
to
if (speaker_num == centroid_num) and (hp.training):

because you do not want to recalculate centroid from evaluation embeddings at the test time.
Wouldn't it be appropriate to use centroids that are calculated solely from enrollment embeddings?

Maybe my understanding on the paper and code is insufficient and I might be missing something. Let me know if I am wrong about this.

Of course it works without fixing it but in my understanding in strict sense, that centroid recalculation is only required for stabilizing training steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant