Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double move confirmation #50

Open
Happy0 opened this issue Dec 14, 2017 · 1 comment
Open

Double move confirmation #50

Happy0 opened this issue Dec 14, 2017 · 1 comment

Comments

@Happy0
Copy link
Owner

Happy0 commented Dec 14, 2017

bebot managed to move twice, somehow...

sbot links --dest "%rRPFDrNIGcg6BOgvza4S3pzdYqHUg0kxVorvdD15F10=.sha256" --values

I suspect because the m.redraw (on hiding confirmation) is in a setTimeout, the 'on confirm' click can rarely fire twice, or something... Tricky times.

Need to:

  • Disable the 'confirm move' button after the first click. Make sure it's re-enabled on the next move, after a redraw.
  • Gracefully recover from a user moving twice on their move by choosing the first move (due to a buggy client implementing the protocol.) Eh, I hope that's the right philosophical approach, anyway :P.
@christianbundy
Copy link
Contributor

Eh, I hope that's the right philosophical approach, anyway :P.

I think so, otherwise you'd be in a position where users could edit their moves after the fact!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants