Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GIF Support #31

Open
TAKeanice opened this issue Aug 8, 2014 · 3 comments
Open

GIF Support #31

TAKeanice opened this issue Aug 8, 2014 · 3 comments

Comments

@TAKeanice
Copy link

One really useful thing to add (though maybe some amount of work) would be when fetched data is a gif, it is automatically split to create an animated UIImage, which is then added to the imageview in a way that it starts animating.

(Also: Thank you for the great library!)

@hpique
Copy link
Member

hpique commented Aug 8, 2014

Thanks @TAKeanice!

While I'm not keen on the idea of adding GIF support to Haneke (too many responsibilities for a single project), I'm not opposed to have a separate Haneke+GIF project that does this.

I would have to add a few extension points to Haneke for that to be possible seamlessly. I will take it into account for future updates.

@TAKeanice
Copy link
Author

My idea was to bind in one of the gif libraries for ios, that already have the capability to decompose provided gif data and deliver an animated UIImage. Then, the only responsibility to add for Haneke would be to recognize gif data and pass it to the gif library, instead of directly instanciating an UIImage from the data.
The user would be responsible for setting the animationRepeatCount on the imageView, but the Haneke could start the animation as soon as the image was set to the imageView (that would have to be added to the imageView category).
(Since I´m really new to gitHub, I don´t know whether it is appropriate to make a fork for such extension of functionality. I also don´t want to burden and annoy you with my request, so please let me know if I do, or whether I should care for that myself)

@BenjaminBriggs
Copy link

I've added support for additional formats. My example shows how it could be used with gifs. See my pull request #81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants