New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetcher retain itself in a success block #108

Open

Shedward opened this issue Jan 24, 2017 · 0 comments

Shedward commented Jan 24, 2017

Hello guys, I just looked through your code searching for the reason of memory leaks in my custom fetcher and found this line of code

Haneke/Haneke/HNKCache.m

Line 262 in 67b52df

NSString *key = fetcher.key;

I don't know if it's intensionally or it's a mistake, but it cause fetcher to live as long as a success block, so you might want to fix it.

BTW, thanks for you for this nice library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment