Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enableOnBackInvokedCallback true #329

Open
rabaimorp opened this issue Apr 22, 2024 · 5 comments
Open

enableOnBackInvokedCallback true #329

rabaimorp opened this issue Apr 22, 2024 · 5 comments
Labels
awaiting api support the api for this feature isn't available yet or not supported anymore enhancement New feature or request feature request This feature should be implemented

Comments

@rabaimorp
Copy link

Support for predictive back animations
Android 14 has a feature that shows you where the back button will take you to.
Looking at the apps beatiful animations, this would certanly add to the experience.

@Hamza417
Copy link
Owner

@rabaimorp It already supports this and also it doesn't use activity for stacking UI so it cannot work within the app

@Hamza417 Hamza417 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 22, 2024
@Hamza417 Hamza417 added enhancement New feature or request wontfix This will not be worked on feature request This feature should be implemented out of scope this feature is deemed out of scope of the app awaiting api support the api for this feature isn't available yet or not supported anymore and removed wontfix This will not be worked on labels Apr 22, 2024
@Hamza417 Hamza417 removed the out of scope this feature is deemed out of scope of the app label May 13, 2024
@Hamza417
Copy link
Owner

Hamza417 commented May 13, 2024

Google recently pushed an update that added the support for predictive back gestures for fragments. However, it created a lot of issues in the app like bottom bar disappearing when back gesture is invoked and cancelling back gesture, causing a series of blank screens. I disabled the predictive gestures completely from the app and will be publishing a hotfix soon until I figure out how to properly implement it and wait for Google to refine the dependency too.

@Hamza417 Hamza417 reopened this May 13, 2024
@Hamza417
Copy link
Owner

You can still test the predictive gesture for the whole app in the Build100.6.0 and let me know what issues you faced while using. This will help me fix issues in the future.

@rabaimorp
Copy link
Author

You can still test the predictive gesture for the whole app in the Build100.6.0 and let me know what issues you faced while using. This will help me fix issues in the future.

Yeah. The main issue was that holding back would not just preview the previous state but actually go back. But after I "cancel" the back gesture I get to a blank screen, instead of just stating where I was originally. I tested this on multiple pages on the app.

@Hamza417
Copy link
Owner

That's the issue, they've already fixed some parts of it in the recent beta release. I'll begin testing it soon in the app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting api support the api for this feature isn't available yet or not supported anymore enhancement New feature or request feature request This feature should be implemented
Projects
None yet
Development

No branches or pull requests

2 participants