Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Python depencies to Python 3 #1077

Open
jfthuong opened this issue Mar 29, 2022 · 3 comments
Open

Migrate Python depencies to Python 3 #1077

jfthuong opened this issue Mar 29, 2022 · 3 comments

Comments

@jfthuong
Copy link

Great Project here!

I found it strange to have dependencies to Python2 to only use it for Git hooks.

I propose to migrate to Python 3 (or at least making it compatible with both Python 2 and Python 3).

The only thing to update in these scripts is actually the print: print "..." => print("...")

jfthuong added a commit to jfthuong/animator that referenced this issue Mar 29, 2022
jfthuong added a commit to jfthuong/animator that referenced this issue Mar 29, 2022
@jfthuong
Copy link
Author

... actually, do we really need this Python dependencies for standard users?

Because as it is only used in Git Hooks, it might only targeted for Developers / Contributors, no?

@jfthuong
Copy link
Author

jfthuong commented Mar 29, 2022

Also, need to update version of node-gyp:

Currently: "node-gyp": "^3.6.3" (see package.json)

That version in list of dependencies is very old and only supports Python 2.7, but support of Python 3 has been added in 2019: nodejs/node-gyp@3d1c60a

The node-gyp version v6.0.0 2019-10-04 supports Python 3.x by default.

At the moment of this issue the latest version of node-gyp is 9.0.0 and supports Python 3.10.

@gumptious Do you think we could upgrade the version of node-gyp?

@emergence75
Copy link

hmm... i think upgrading node-gyp, could also solve this little problem here
#1075

Willienn pushed a commit to Willienn/Next-animator that referenced this issue Nov 16, 2022
Willienn pushed a commit to Willienn/Next-animator that referenced this issue Nov 16, 2022
danielnichols pushed a commit to danielnichols/haiku-animator that referenced this issue Apr 1, 2024
danielnichols pushed a commit to danielnichols/haiku-animator that referenced this issue Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants