Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Fbits to Wake #16

Closed
wants to merge 4 commits into from
Closed

Conversation

rviscomi
Copy link
Member

Fixes #15 cc @Angeesantos

src/technologies/f.json Show resolved Hide resolved
src/technologies/w.json Outdated Show resolved Hide resolved
@Angeesantos
Copy link

Hello!

Our main header is "X-Powered-By": "Wake", that all of our sites got. So, even thought some old sites still got Fbits variable, they are already in the model header.

In this case, we can delete Fbits json on the project, replacing it for Wake json.

"Wake": {
   "cats": [
     6
   ],
   "description": "Wake is an ecommerce software with integrated digital solutions to manage online stores.",
   "headers": {
     "X-Powered-By": "Wake"
   },
   "icon": "Wake.png"
   
   "saas": true,
   "website": "https://wake.tech/"

Co-authored-by: Barry Pollard <barrypollard@google.com>
Copy link

@Angeesantos Angeesantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our main header is "X-Powered-By": "Wake", that all of our sites got. So, even thought some old sites still got Fbits variable, they are already in the model header.

In this case, we can delete Fbits json on the project, replacing it for Wake json.

src/technologies/w.json Outdated Show resolved Hide resolved
Co-authored-by: Rick Viscomi <rviscomi@users.noreply.github.com>
@rviscomi
Copy link
Member Author

rviscomi commented Mar 4, 2024

Error: No such icon: Wake.png (Wake)

@Angeesantos can you also add the Wake logo to the icons directory?

@Angeesantos
Copy link

Error: No such icon: Wake.png (Wake)

@Angeesantos can you also add the Wake logo to the icons directory?

Hello Rick,

Can you confirm if it's Wake logo or just an icon, because adding the logo it happens to get smaller and almost impossible to see it. So, if it can be Wake icon, like this file, I'll do it.

Group 1 (1)

@nilsocjr nilsocjr mentioned this pull request Mar 7, 2024
Changed the icon name for wakecommerce.svg as the Wake icon it's already in the repository.
@Angeesantos
Copy link

Angeesantos commented Mar 8, 2024

Good morning @rviscomi

Nilso added wake icon at the repository: #18
And I just changed the icon name at the json.

Can you check if it's all done now and merge the pull request, please.

@tunetheweb tunetheweb mentioned this pull request Mar 9, 2024
"cats": [
6
],
"icon": "Fbits.png",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file needed to be deleted.

I've opened a new PR for this at #19 since I'm not able to edit this branch.

@tunetheweb
Copy link
Member

Fixed in #19

@tunetheweb tunetheweb closed this Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename Fbits to Wake
3 participants