Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tech report page weight formatting #853

Open
rviscomi opened this issue May 2, 2024 · 1 comment
Open

Improve tech report page weight formatting #853

rviscomi opened this issue May 2, 2024 · 1 comment
Assignees

Comments

@rviscomi
Copy link
Member

rviscomi commented May 2, 2024

image

In this screenshot the image weight is shown as "752149 kB"

This seems to be showing the number of bytes, not KB. Let's convert from bytes to KB and if the value is still larger than 1000, convert again from KB to MB. Round to the nearest whole value to avoid showing any decimal places.

Also, as in the existing Page Weight report we typically format the unit as capital-K "KB":

image
@tunetheweb
Copy link
Member

Relevant: #643

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants