Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing histogram data for Nov 15, 2010 #612

Open
alex-bender opened this issue Jun 18, 2022 · 10 comments
Open

Missing histogram data for Nov 15, 2010 #612

alex-bender opened this issue Jun 18, 2022 · 10 comments

Comments

@alex-bender
Copy link

image
https://cdn.httparchive.org/reports/top1k/2010_11_15/speedIndex.json

Response { type: "cors", url: "https://cdn.httparchive.org/reports/top1k/2010_11_15/bootupJs.json", redirected: false, status: 404, ok: false, statusText: "Not Found", headers: Headers, body: ReadableStream, bodyUsed: false }
histogram.js:1:4233
@tunetheweb
Copy link
Member

The ranking lenses (top 1000, 10000… 1 million) were only added from May 2021 so didn’t exist for 2010.

@rviscomi
Copy link
Member

One could argue that we shouldn't show start/end options for dates that we know are not supported by the lens. For example, some metrics provide a min/max date when we know about its availability window. Perhaps we should do the same for lenses.

"bytesVideo": {
"name": "Video Bytes",
"type": "KB",
"description": "The sum of transfer size kilobytes of all videos requested by the page. A video is identified as a resource with the `mp4`, `swf`, `f4v`, or `flv` file extensions or a MIME type containing `flash`.",
"histogram": {
"minDate": "2015_05_01"
}
},

@tunetheweb
Copy link
Member

Potentially, but can also result in fighting the GUI and confusing users.

For example I'm in 10k lens (only available for 2022). I want as much WordPress data as possible. If the date was filtered, I might not realise there is a lot more than for 10k, and at the very least there's two steps.

So both ways have their downfalls.

Maybe a better option would potentially be to leave the date pickers alone, but use an error message (where it's less obvious what the limits are than for the timeseries):

"Error: Histograms for 10k are only available from April 2022"

@alex-bender
Copy link
Author

as a general rule, I suppose, if error could be precalculated\predicted, it's better to notify user beforehand

@rviscomi rviscomi reopened this Jun 21, 2022
@rviscomi
Copy link
Member

Reopening so we can continue thinking through our options

@alex-bender
Copy link
Author

would it be possible to change it from dropdown to choicefiled?

@rviscomi
Copy link
Member

@alex-bender any interest in drafting that in a pull request?

@alex-bender
Copy link
Author

sure, will try to do that tomorrow

@mgifford
Copy link

Any progress on this @alex-bender

@alex-bender
Copy link
Author

Hey, thanks for the ping. Looks like I can win longest stalled issue challenge.
Could you please describe a bit more what should be done since I'm not fully understand what's exactly should be done?

If there should be error message or notification, where should it be placed. In what case should it be displayed and so on..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants