Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take learnings from Web Almanac site and apply to main httparchive site #250

Open
27 of 32 tasks
tunetheweb opened this issue Apr 24, 2021 · 3 comments
Open
27 of 32 tasks
Labels
dev Development Task for the site or Tech Stack

Comments

@tunetheweb
Copy link
Member

tunetheweb commented Apr 24, 2021

We learned a lot from making the Web Almanac site and it follows a lot of best practices, particularly in terms of Accessibility, Performance, SEO and automation to ensure we stay at the top of that.

We should bring those learnings here and align the web sites, which will also make them easier to maintain together.

Making a list so I don't forget anything:

Feel free to add to this as you see fit, and grab some if they seem of interest. I'll start will work my way through them anyway.

@tunetheweb tunetheweb added the dev Development Task for the site or Tech Stack label Apr 24, 2021
@tunetheweb
Copy link
Member Author

Made quite a bit of progress with this, however the Accessibility improvements in particular have necessitated some changes:

  • Some of the text had bad colour contrast, including the sub-headings:

image

and the table headings:

image

And our links:

image

Made them dark enough to pass colour-contrast checkers, which maybe doesn't follow the original style - the sub headings are now the same colour but I couldn't get a grey that passed:

image

The links also blend in a bit more to the text when darker, but I brought back the underlines (except for menu links) which helps:

image

Also a lot of the links had the same names ("View reports", "Learn more"...etc.) so made them a bit more descriptive.

Also added a few missing <h1>s which sometimes resulted in a slight style change.

Other than those, most of the above changes shouldn't result in any noticeable change (except to AT users and search engine crawlers!).

@rviscomi once we decide on #256 could you give this a a good going over (as quite a lot of change!) and then let's do a release?

@rviscomi
Copy link
Member

Sounds good. Thanks for working on this—these are some long-overdue improvements! 🙌

@tunetheweb
Copy link
Member Author

OK merged everything I'm gonna merge for now. If you could have a good look over it @rviscomi that would be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Development Task for the site or Tech Stack
Projects
None yet
Development

No branches or pull requests

2 participants