Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug report/ Help watnted: #270

Open
yannqi opened this issue Nov 17, 2022 · 0 comments
Open

Bug report/ Help watnted: #270

yannqi opened this issue Nov 17, 2022 · 0 comments

Comments

@yannqi
Copy link

yannqi commented Nov 17, 2022

In this line : https://github.com/HRNet/HRNet-Semantic-Segmentation/blob/HRNet-OCR/lib/models/seg_hrnet_ocr.py#L64

Question:
According to this line,
probs = F.softmax(self.scale * probs, dim=2)# batch x k x hw
In this code, the input dimension is [batch_size, num_class, fh*fw].
And the softmax dimension is 2, which means that the summation of the dimensions of the feature map (fh*fw) is one.

However, in my opinion, I thinke the softmax dimension should be 1 to make the summation of the dimension of the num_class (num_class) is one.

The corrected code is as follows:
probs = F.softmax(self.scale * probs, dim=1)# batch x num_class x hw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant