Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatible with VisualStudio 2022 #222

Open
phpfs opened this issue Feb 28, 2022 · 1 comment
Open

Incompatible with VisualStudio 2022 #222

phpfs opened this issue Feb 28, 2022 · 1 comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file

Comments

@phpfs
Copy link
Collaborator

phpfs commented Feb 28, 2022

The better-sqlite3 version we use depends upon an old version node-gyp that is incompatible with VisualStudio 2022 (which is used in windows-latest in CI). See issue nodejs/node-gyp#2520 for details.

As a quick fix, we pinned the GH actions to windows-2019 in the packaging workflow, but need to fix this before the next release!
@phpfs phpfs added bug Something isn't working dependencies Pull requests that update a dependency file labels Feb 28, 2022
@phpfs
Copy link
Collaborator Author

phpfs commented May 20, 2022

Since better-sqlite3 is now upgraded to the latest version, we can potentially resume building on the latest windows image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@phpfs