New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md to include plug submodule #210
Conversation
I _think_ this is correct? I was going nuts trying to figure out how Gwion was supposed to actually make sound ...
Sorry about that. That's clearly a problem in the documentation. It's fine if you PR something in the docs when we're done with this PR. However, I you're willing to do more, there are lots of points we can address
Thank you for your interrest and questions, it helps me clarify the current state of the project. EDIT: If you still have trouble having sound, please let me now, either by answering or rising an issue. HINT: I you are to use, say, the Jack driver, you need to pass Hope this helps. |
Would you be OK to merge? |
I'm going to revise my text a bit before I submit it. |
Please take a look at this before I merge. A few issues are (1) it only talks about linux/jack (don't really know about other OSes), and (2) it assumes we can get the soundpipe lib to build as part of the Soundpipe plugin build (I'm assuming here that the Soundpipe module will link with the static soundipipe.a library). |
@fennecdjay It seems I can't acutally merge this myself. I think being on the Gwion project and being a maintainer for this repo are two different things -- another reason to move this repo under the Gwion project. In any case I wanted you to look at it; what I wrote about getting sound is totally linux-centric, and I don't know if we need some OS X language in there as well (although I don't develop on OS X so it would be hard for me to write). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mayb
I suggested some fixes, maybe you can add them and try to merge (I'm not sure yet you have those rights, it'll be nice to check). This clearly opens the problem of handling submodules/dependencies in the plug submodule. 👍 |
Incorporated changes suggested by @fennecdjay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Can you merge it? |
It looks like I still don't have the required permissions to merge PRs into this repo. |
Ok, checking that. |
Can you merge now? |
Merged! |
I think this is correct? I was going nuts trying to figure out how Gwion was supposed to actually make sound ...
I'll make the corresponding change in the docs (only) if you confirm this is correct.
(Pretty cheesy for a Hacktoberfest PR, I know ... I'll try to write some actual code once I get Gwion to actually work and stuff.)