Skip to content
This repository has been archived by the owner on Oct 17, 2021. It is now read-only.

Missing logic in FP processing #43

Open
Guillawme opened this issue Mar 15, 2018 · 1 comment
Open

Missing logic in FP processing #43

Guillawme opened this issue Mar 15, 2018 · 1 comment
Labels

Comments

@Guillawme
Copy link
Owner

As it is now, processing FP data with format_data(data_type = "FP") will fail if the input datasets don't contain the polarization, anisotropy and intensity columns.

There should be some logic checking that these columns are present, and if not we should generate them using fp_calculate_pola_aniso_int() (and this function can then become internal). This must be done after mapping internal column names to the actual names designated by the metadata file, because fp_calculate_pola_aniso_int() relies on these internal names.

Overview of this logic:

  • set column names according to metadata files;
  • check for polarization, anisotropy and intensity columns;
  • if not present, calculate them with fp_calculate_pola_aniso_int().
@Guillawme Guillawme added the bug label Mar 15, 2018
@Guillawme
Copy link
Owner Author

Or, alternative way: ignore pre-calculated polarization, anisotropy and intensity and always recalculate them with fp_calculate_pola_aniso_int(). This would make the metadata file simpler than it is now, as the user would only need to indicate raw data (parallel and perpendicular) column names.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant