Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2FA support #52

Open
confact opened this issue Mar 21, 2022 · 2 comments
Open

2FA support #52

confact opened this issue Mar 21, 2022 · 2 comments
Labels
discussion enhancement New feature or request

Comments

@confact
Copy link

confact commented Mar 21, 2022

I was looking for a login solution in lucky for one of my apps. Looks good!

The only thing I am missing is OTP/2FA support. With Google Authentication or Authy, it would be amazing, making it very secure.

@akadusei akadusei added enhancement New feature or request discussion labels Mar 23, 2022
@akadusei
Copy link
Contributor

I was looking for a login solution in lucky for one of my apps. Looks good!

Glad to know.

The only thing I am missing is OTP/2FA support.

I think so too. An ideal 2FA integration should allow multiple methods (at least TOTP and email). Overall, it seems it would require a non-trivial amount of time to design and build.

I am currently tied up on a project, so time is not my friend now. If you have any ideas or PR, that would be great. I'll try to squeeze in some time and work on a design. We'll see.

There's already a TOTP implementation here: https://github.com/Axentro/crystal-two-factor-auth. I haven't used it in any way, but it looks good, and looks like it would save some amount of work.

@notramo
Copy link

notramo commented May 7, 2023

Ideal implementation would be to have pluggable providers (e.g. TOTP, HOTP, FIDO, random token generation fro SMS/email, etc.), and pluggable transports: none for TOTP, FIDO because it's already on the device, or SMS/email/Matrix, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants