Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules #80

Open
victorstewart opened this issue Sep 20, 2019 · 4 comments
Open

modules #80

victorstewart opened this issue Sep 20, 2019 · 4 comments

Comments

@victorstewart
Copy link

would be great to in some way streamline the ability to add modules. right now i'm just editing the dockerfile and boot script to build and load them.

any ideas?

@Grokzen
Copy link
Owner

Grokzen commented Sep 22, 2019

I have never used a module inside redis so i have no idea in how to integrate or make them enabled or loaded upon a container build or start really.

@Grokzen
Copy link
Owner

Grokzen commented Sep 22, 2019

One major problem tho is that i do not want to maintain a big repo of all possible redis modules in-sourced into this repo and available to be ued either through env variables or through some script. Yes documentation of how to do it can be added, but i dont know what else that can really be done more then that right now unless you have some great ideas of a sustainable solution to source things in?

@victorstewart
Copy link
Author

victorstewart commented Sep 22, 2019

i’m cool with just continuing to hack the files, just thought it might be a useful expansion.

it’s actually super straightforward. when booting redis-server all you do is pass in...

--loadmodule /path/to/mymodule.so

sorry on mobile otherwise i’d format lol.

so the simplest way to get it done would be to pass in a list of the precompiled modules, copy them into the image and then link.

could also pass in repository links, and assume a standard ./configure && make complication pattern. but that gets a bit beyond straightforward.

@Grokzen
Copy link
Owner

Grokzen commented Dec 9, 2019

Currently i have no plans to add any support for modules to this container myself. Anyone that want to propose a simple and straightforward solution to this is more then welcome to provide a patch that would add support for this. The only solution that i would consider be acceptible is to have a volume mapped from your host into the container that contains the compiled modules files and then provide a option or argument or something to pass into the container when it starts that would append and load the modules into all the redis nodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants