Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the attribute background useless? #91

Open
ZhangChengLin opened this issue Aug 14, 2021 · 1 comment
Open

Is the attribute background useless? #91

ZhangChengLin opened this issue Aug 14, 2021 · 1 comment

Comments

@ZhangChengLin
Copy link

$this->background = $bg;

Is the background useless? It is still related to distort in line 480, because $bg in line 480 does not necessarily work.
I am not quite sure, so I dare not submit a PR rashly, please confirm.

$image = $this->distort($image, $width, $height, $bg);

@visavi
Copy link
Contributor

visavi commented Sep 2, 2021

Yes, there is a problem with this, but you can turn off all the effects, then it will work

$builder->setBackgroundImages($backgrounds);
$builder->setIgnoreAllEffects(true);

@S1SYPHOS S1SYPHOS mentioned this issue Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants