Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddpCollection.reactive() doesn't accept { sort } #13

Open
fixmaker opened this issue Sep 10, 2019 · 1 comment
Open

ddpCollection.reactive() doesn't accept { sort } #13

fixmaker opened this issue Sep 10, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@fixmaker
Copy link

Hello, and thanks for a great library!

Although the documentation implies that the following should be possible:

server.collection('widgets').reactive({ sort: mySortFunc })

It appears that the sort function is being ignored. After investigating and running some traces on the code, it looks like it's not being set at all. The constructor of ddpReactiveCollection doesn't process the sort property.

This isn't a major problem since I can rewrite the code above as follows:

server.collection('widgets').reactive().sort(mySortFunc)

...and it works as expected. But either the documentation should probably be updated, or the code fixed to work as documented.

@Gregivy
Copy link
Owner

Gregivy commented Sep 21, 2019

Hello, @fixmaker. Thanks for your review! I'll correct the code soon.

@Gregivy Gregivy added the bug Something isn't working label Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants