Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefix to storage config #69

Open
joao-zanutto opened this issue Apr 14, 2024 · 1 comment · May be fixed by #72
Open

Add prefix to storage config #69

joao-zanutto opened this issue Apr 14, 2024 · 1 comment · May be fixed by #72

Comments

@joao-zanutto
Copy link
Contributor

As discussed in #56, the storage.prefix config should be added to work with both storage types directory and s3, meaning that s3.prefix will be deprecated.

Concerns:

  • Will storage.directory.path config remain the same or should it be removed to make place to storage.prefix as well?
    • if so, which will the final storage path given the user configuration defines both?
      • {{ storage.prefix }} / {{ storage.directory.path }} or
      • {{ storage.directory.path }} / {{ storage.prefix }}
@wwoytenko
Copy link
Contributor

The easiest one is storage.prefix. We could provide a path prefix as a parameter in the constructor

@joao-zanutto joao-zanutto linked a pull request Apr 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants