Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add prefix to storage config #72

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

add prefix to storage config #72

wants to merge 3 commits into from
+15 −8

Conversation

joao-zanutto
Copy link
Contributor

  • move storage.s3.prefix to storage.prefix
  • prefix now works with directory storage
  • prefix should have the same functionality in s3 storage

closes #69

@wwoytenko
Copy link
Contributor

@joao-zanutto could you please implement the parameter --storage-prefix for cmd in this PR as well?

wwoytenko
wwoytenko requested changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@wwoytenko wwoytenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add --storage-prefix parameter as well

internal/storages/directory/directory.go
@@ -188,3 +188,10 @@ func (d *Storage) SubStorage(dp string, relative bool) storages.Storager {
fileMode: d.fileMode,
}
}

func fixPrefix(prefix string) string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is doubled. Could you move this function into let's say internal/utils/config and make this function public (uppercase first letter)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wwoytenko wwoytenko wwoytenko requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add prefix to storage config
2 participants
@joao-zanutto @wwoytenko