Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unmarshal dump.transformation from env variable #61

Closed
wants to merge 1 commit into from

Conversation

joao-zanutto
Copy link
Contributor

@joao-zanutto joao-zanutto commented Apr 8, 2024

  • Enable dump transformation configuration through environment variable DUMP_TRANSFORMATION using JSON

closes #60

@joao-zanutto
Copy link
Contributor Author

joao-zanutto commented Apr 10, 2024

@wwoytenko I spent some time debugging and after a while I realized that this PR actually solves the problem entirely, as described in my update in the latest comment in #60

@wwoytenko
Copy link
Contributor

I will check it carefully on this week. I have to check the custom transformers protocol that is not described in the docs but implemented. I will let you know once it is validated

@wwoytenko
Copy link
Contributor

I believe I will be able to check it only in the next week.

@wwoytenko
Copy link
Contributor

According to the limitation of mapstructure and viper we can't publish this because it raises #76

The related issue is there

I've just implemented workaround #80 and it is not backward compatible with this PR

@wwoytenko wwoytenko closed this Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: add JSON parsing to dump.transformation attribute
2 participants