Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move sci to if/builtins #682

Closed
6 tasks done
Tracked by #656
zanete opened this issue Apr 29, 2024 · 2 comments · Fixed by #704
Closed
6 tasks done
Tracked by #656

Move sci to if/builtins #682

zanete opened this issue Apr 29, 2024 · 2 comments · Fixed by #704
Assignees
Labels
epic: QA task inside the QA epic

Comments

@zanete
Copy link

zanete commented Apr 29, 2024

Sub of: #656

What
Move the sci plugin from if-plugins to if/builtins

Why
This is part of our migration of our core plugins into a standard library in if/builtins.

Context
This is a core feature we want to support, so it is migrating into if.

Prerequisites/resources
no

SoW (scope of work)

  • move plugin code into builtins/sci
  • fix any integration issues caused by the migration
  • migrate and fix unit tests
  • update README documentation updated

Acceptance criteria

  • plugin code is migrated to if-builtins
    Given (Setup): The migration has been completed.
    When (Action): A user or developer navigates to if
    Then (Assertion): they will find a folder if/builtins/sci containing the plugin source code and a README.

  • plugin code and unit tests pass and maintain 100% coverage
    Given (Setup): The migration has been completed and a user has downloaded if.
    When (Action): they run npx jest --coverage
    Then (Assertion): they will receive a report showing 100% coverage and 100% passing

@zanete
Copy link
Author

zanete commented May 20, 2024

@manushak to do second review

@zanete zanete assigned manushak and unassigned narekhovhannisyan May 20, 2024
@jmcook1186 jmcook1186 linked a pull request May 20, 2024 that will close this issue
9 tasks
@manushak
Copy link
Contributor

@manushak to do second review

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic: QA task inside the QA epic
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants