Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking on submit button in create / update event notification form shows confirm dialog. #19014

Closed
linuspahl opened this issue Apr 11, 2024 · 5 comments · Fixed by #19073
Closed

Clicking on submit button in create / update event notification form shows confirm dialog. #19014

linuspahl opened this issue Apr 11, 2024 · 5 comments · Fixed by #19073
Assignees
@linuspahl
Labels
blocker If not finished by release date, the release will be postponed. bug needs-backport test-day triaged
Milestone
6.0.1

Comments

@linuspahl
Copy link
Contributor

linuspahl commented Apr 11, 2024 •
edited

Description

When you create or update an event notification, you will see the following confirm dialog on submit. Tested with an http notification.

image

Seems to be related to #19008

  • Graylog Version: 6.0
@kmerz kmerz added blocker If not finished by release date, the release will be postponed. triaged and removed blocker If not finished by release date, the release will be postponed. labels Apr 12, 2024
@kmerz
Copy link
Member

kmerz commented Apr 12, 2024

Duplicate of #18771 the PR needs a backport (#18880)

@kmerz kmerz added the blocker If not finished by release date, the release will be postponed. label Apr 12, 2024
@kmerz kmerz assigned kmerz and zeeklop and unassigned kmerz Apr 12, 2024
@zeeklop
Copy link
Contributor

zeeklop commented Apr 12, 2024

This solution was applied to 6.0rc on the this PR #18900

@linuspahl
Copy link
Contributor Author

@zeeklop The PR looks event definitions related, should it also fix the problem for the notifications form?

@linuspahl
Copy link
Contributor Author

@kmerz it looks like the issue you mentioned is about event definitions, but I had this problem with the event notifications form.

@zeeklop
Copy link
Contributor

zeeklop commented Apr 12, 2024

@zeeklop The PR looks event definitions related, should it also fix the problem for the notifications form?

@linuspahl This is only taking care of the issue on Event Definitions form.

@linuspahl linuspahl assigned linuspahl and unassigned zeeklop Apr 16, 2024
@linuspahl linuspahl mentioned this issue Apr 16, 2024
Merged
@kmerz kmerz modified the milestones: 6.0.1, 6.0.0 Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@linuspahl linuspahl

Labels
blocker If not finished by release date, the release will be postponed. bug needs-backport test-day triaged
Projects
None yet
Milestone
6.0.1
Development

Successfully merging a pull request may close this issue.

Do not show confirm dialog when saving event notification. Graylog2/graylog2-server
3 participants
@kmerz @linuspahl @zeeklop