Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast exception #69

Open
samuelecollu opened this issue May 17, 2016 · 4 comments
Open

Cast exception #69

samuelecollu opened this issue May 17, 2016 · 4 comments

Comments

@samuelecollu
Copy link

Hi, first of all thanks for the great work you are doing.

I'd like to report an issue that could be easily solved.
When i filter on integer fields i have a cast exception. After a look to the source code i found the problem.
In the class FilterPaneService, line 371 there is
newValue.isInteger() ? newValue.toInteger() : null
but i think should be something like this
newValue = newValue.isInteger() ? newValue.toInteger() : null
is the same for the other field types (double, float, bigdecimal, biginteger)

@bratekarate
Copy link
Contributor

bratekarate commented Dec 12, 2016

Fixed and created pull request #71

Is there anybody even working on this plugin anymore? I need to know if this will be accepted and shipped as a new version or if I have to deploy my custom artifact to my personal maven repository.

Edit: Tests have failed, but that cannot be related to my changes.

@ctoestreich
Copy link
Member

I still keep an eye and release for PR. I am not actively improving this myself. The original author abandoned and I just man the releases these days instead of letting it die.

@bratekarate
Copy link
Contributor

@ctoestreich Thanks for the fast reply. So another version will be released? Can you already give an approximate estimate when the new version will be available for use?

@Andrauss
Copy link

Any prevision?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants