Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

track: Some (small) changes before 0.8 #758

Open
4 of 8 tasks
daudix opened this issue Apr 16, 2023 · 4 comments · Fixed by #816 · May be fixed by #882
Open
4 of 8 tasks

track: Some (small) changes before 0.8 #758

daudix opened this issue Apr 16, 2023 · 4 comments · Fixed by #816 · May be fixed by #882
Labels
enhancement New feature or request feature-request good first issue Good for newcomers wishlist
Milestone
0.8.0

Comments

@daudix
Copy link
Member

daudix commented Apr 16, 2023 •
edited

To-Do

A few things that would be good to do before 0.8 but are not blockers, tracked in this list to not forget about them

  • Make drag-and-drop work between color buttons (drag the color from one button to another, doesn't change the color value right now)
  • Fix rename text box in Preset Manager revealing from right and not left as in main window track: Some (small) changes before 0.8 #758 (comment)
  • feat: Color mixing for Monet generation #736
  • Replace logout message with toast HIG
  • Make something with translator-credits, I have made it vary from lang to lang, but now link/mail is broken as Weblate is confused by using XML syntax in Python file
  • Not sure Add support for Thumbnail Colors
  • Simplify welcome window by removing useless steps like selecting theming options and installing themes pages

Additional Context

No response

Did you read the Code of Conduct?
@daudix daudix added enhancement New feature or request feature-request labels Apr 16, 2023
@daudix daudix added this to the 0.8.0 milestone Apr 16, 2023
@daudix daudix changed the title feat: Some (small) changes before 0.8 track: Some (small) changes before 0.8 Apr 16, 2023
@tfuxu
Copy link
Member

tfuxu commented Apr 16, 2023

There's no need to move to the new 4.10 widgets, as the old ones will be removed in GTK 5, which isn't even in the workings yet. Porting now would make Gradience incompatible with most native users, so I would wait with moving to new widgets until at least 4.10 will be available in most distributions.

Check out October post on GTK blog talking about 4.10 deprecations for more info: https://blog.gtk.org/2022/10/

@daudix
Copy link
Member Author

daudix commented Apr 16, 2023 •
edited

Fix rename text box in Preset Manager revealing from right and not left as in main window

This can be fixed by making rename button the first button in a row, this is also a good chance to use the new layout [rename / apply / star]

I have tried to do this but for some reason rename button disappears after clicking on it, so I guess I did something wrong :)

@tfuxu tfuxu added the good first issue Good for newcomers label May 14, 2023
@0xMRTT
Copy link
Member

0xMRTT commented Sep 4, 2023

@daudix-UFO can you explain

Make DnD between color buttons work (you can drag the color from one button to other but it doesn't change the color value right now)

Is it this ?
image

@daudix
Copy link
Member Author

daudix commented Sep 4, 2023

No, I mean the color button in gradience itself can be dragged on the other button, and it will copy the color, but hex itself doesn't respect this

0xMRTT added a commit that referenced this issue Sep 4, 2023
@0xMRTT
fix: replace logout dialog with a toast (#758)
212aef6
@0xMRTT 0xMRTT mentioned this issue Sep 4, 2023
Merged
5 tasks
daudix added a commit that referenced this issue Sep 4, 2023
@daudix
fix: replace logout dialog with a toast (#758) (#816)
5cdcfc9 
## Description

Replace logout message with toast
[HIG](https://developer.gnome.org/hig/patterns/feedback/toasts.html)

Fixes #758 

## Type of change

<!-- What type of change does your pull request introduce? Put an `x` in
the appropriate box . -->
- [ ] Bugfix (Change which fixes an issue)
- [ ] New feature (Change which adds new functionality)
- [x] Enhancement (Change which slightly improves existing code)
- [ ] Breaking change (This change will introduce incompatibility with
existing functionality)

## Testing

- [x] I have tested my changes and verified that they work as expected
<!-- Make sure you did this step before marking your PR as ready for
merge. -->
@0xMRTT 0xMRTT reopened this Sep 4, 2023
@orhosko orhosko linked a pull request Apr 11, 2024 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request feature-request good first issue Good for newcomers wishlist
Projects
Gradience
Status: In Progress
Milestone
0.8.0
3 participants
@tfuxu @daudix @0xMRTT