Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gnome 46 support and Panel theming #881

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Gnome 46 support and Panel theming #881

wants to merge 2 commits into from
+454 −17

Conversation

orhosko
Copy link

@orhosko orhosko commented Apr 11, 2024 •
edited

Description

This adds basic support for gnome 46. However, it requires changes and decisions, so help is required.

Fixes #878 #871

Type of change

  • Bugfix (Change which fixes an issue)
  • New feature (Change which adds new functionality)
  • Enhancement (Change which slightly improves existing code)
  • Breaking change (This change will introduce incompatibility with existing functionality)

Changelog

  • Gnome 46 support:

    • for template i copied 45/ and added missing values.
    • for submodule part waiting this pr to merge.
    • Contrast mode set as normal for now. If there is a need, ui and template should be updated.

  • Panel theming:

    • For a temporary fix, it uses the same color as trays. I believe it can be edited using css and if there is a need it can be discussed in separate issue.

Testing

  • I have tested my changes and verified that they work as expected

I haven't tested for earlier gnome versions.

github-actions[bot]
github-actions bot reviewed Apr 11, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome on Gradience. 🥳 We really appreciate your contribution. The core team will review your pull request as soon as possible. You can also join the Matrix room: https://matrix.to/#/#Gradience-space:envs.net or the Discord server: https://discord.com/invite/4njFDtfGEZ.

@orhosko orhosko marked this pull request as draft April 11, 2024 00:28
@orhosko orhosko changed the title partial: Gnome 46 support and Panel theming draft: Gnome 46 support and Panel theming Apr 11, 2024
@orhosko orhosko marked this pull request as ready for review April 11, 2024 15:59
@orhosko orhosko changed the title draft: Gnome 46 support and Panel theming Gnome 46 support and Panel theming Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panel calendar month and weekday colours.
1 participant
@orhosko