Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Top-Left Corner Of LibAdwaita apps are still using Default Theme #828

Open
2 tasks done
heinthanth opened this issue Oct 12, 2023 · 11 comments
Open
2 tasks done
Labels
type/bug Something isn't working

Comments

@heinthanth
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

Using Gradience Nightly, I applied Presets. And navigation-sidebar color is correct now. But top-left corner of navigation-sidebar is still using default theme. I also attached a screenshot. Thanks! I really love this application.

To Reproduce

  1. Open Gradience
  2. Load presets ( which is different from default Adwaita theme )
  3. Click Apply
  4. Logout/Login or Restart ( I tried restart )
  5. Open nautilus or gnome-control-center or contact apps, etc.
  6. Observe the top-left corner

Expected behavior

Top-left corner also utilize the customized color setting.

Screenshots

image

OS

Arch Linux

DE/WM version

GNOME 45.0, Mutter

Version

0.3.1.r2.ge5dd5c9-1

Installation method

AUR

Enabled system extensions (GNOME specific)

$ gnome-extensions list --enabled

arcmenu@arcmenu.com
dash-to-dock@micxgx.gmail.com
vertical-workspaces@G-dH.github.com
clipboard-indicator@tudmotu.com
appindicatorsupport@rgcjonas.gmail.com
places-menu@gnome-shell-extensions.gcampax.github.com
user-theme@gnome-shell-extensions.gcampax.github.com

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@heinthanth heinthanth added the type/bug Something isn't working label Oct 12, 2023
@github-actions
Copy link
Contributor

Welcome on Gradience. 🥳 We really appreciate your contribution. The core team will review your issue as soon as possible. You can also join the Matrix room: https://matrix.to/#/#Gradience-space:envs.net or the Discord server: https://discord.com/invite/4njFDtfGEZ

@heinthanth
Copy link
Author

image

Background color of Nautilus picker also wrong.

@hydroxycarbamide
Copy link

I think the fix of #815 does not fix all the issues (for both gtk4 libadwaita .config/gtk-4.0/gtk.css and gtk3 adw-gtk3 .config/gtk-3.0/gtk.css):

.navigation-sidebar {
	background-color: rgb(36, 39, 58);
}

This class does not include all of the sidebar (as you could probably tell from the previous screenshots).

The fix might be to use these variables: sidebar_bg_color, sidebar_fg_color, sidebar_border_color, sidebar_backdrop_color, sidebar_shade_color and remove the navigation-sidebar class.

For exemple on my side, I use this gtk.css for GTK4 and this gtk.css for GTK3 adw-gtk3. As you can see those variables are just copies of their equivalent header_* variables. (so sidebar_bg_color is simply header_bg_color).

For GTK4, it works fine.

image

However there is still an issue in my GTK3's gtk.css. When hovering the sidebar with the cursor, the highlight color is not shown. But overall it works well enough :

image

@heinthanth
Copy link
Author

heinthanth commented Oct 12, 2023

Thanks @hydroxycarbamide, For now, I added those custom variables in Custom css box for both GTK 4 and 3. And it works well!

@define-color sidebar_bg_color @window_bg_color;
@define-color sidebar_fg_color @window_fg_color;
@define-color sidebar_border_color @window_bg_color;
@define-color sidebar_backdrop_color @window_bg_color;

@0xMRTT
Copy link
Member

0xMRTT commented Oct 12, 2023

This New vars are included in the latest version of gradience not yet released

@thiagolucio
Copy link

Thanks @hydroxycarbamide, For now, I added those custom variables in Custom css box for both GTK 4 and 3. And it works well!

@define-color sidebar_bg_color @window_bg_color;
@define-color sidebar_fg_color @window_fg_color;
@define-color sidebar_border_color @window_bg_color;
@define-color sidebar_backdrop_color @window_bg_color;

Thanks for sharing this solution Dude. Works like a charm in my Gnome.
Thanks a \o/!

@keilmillerjr
Copy link

@hydroxycarbamide Fix resolved the issue with the gradience theme not being applied to the top left of nautilus. However, there is a dark thin line dividing the files hamburger menu and the navigation/path/query/view/close section. Any ideas?

[arch]
adw-gtk-theme
gradience-git
libadwaita-without-adwaita-git
nautilus

@keilmillerjr
Copy link

@hydroxycarbamide Fix resolved the issue with the gradience preset not being applied to the top left of nautilus. However, there is a dark thin line dividing the files hamburger menu and the navigation/path/query/view/close section. Any ideas?

2024-02-07T12:07:43,652662862-05:00

[arch]
adw-gtk-theme
gradience-git
libadwaita-without-adwaita-git
nautilus

@daudix
Copy link
Member

daudix commented Feb 7, 2024

It's probably a headerbar or a sidebar shade color

@xynydev
Copy link

xynydev commented Feb 11, 2024

I'm not sure if this is related, but for me with the official Catppuccin Mocha theme the sidebar of Libadwaita applications such as Nautilus is broken, with the top left issue and badly coloured text.

image

@keilmillerjr
Copy link

I'm not sure if this is related, but for me with the official Catppuccin Mocha theme the sidebar of Libadwaita applications such as Nautilus is broken, with the top left issue and badly coloured text.

image

Yes. See the temporary fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

7 participants