Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent set_gtk3_theme from crashing #813

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lavafroth
Copy link
Contributor

Description

When using GSettingsSetting outside a flatpak environment, the added getter, setter and reset methods should prevent the AttributeError when attempting to set the GTK3 theme.

Note: I used python-black for formatting the code and it made a lot of weird opinionated changes.

Fixes #811

Type of change

  • Bugfix (Change which fixes an issue)
  • New feature (Change which adds new functionality)
  • Enhancement (Change which slightly improves existing code)
  • Breaking change (This change will introduce incompatibility with existing functionality)

Changelog

  • Adds a function to stage the gsettings command to be executed.
  • Adds the equivalent setter, getter and reset functions for GSettingsSetting.

Testing

  • I have tested my changes and verified that they work as expected

How to test the changes

Run ./local.sh in a non-flatpak environment, apply a theme, making sure to check the GTK3 checkbox. The program should ask you to log out to see the effects.

@daudix daudix requested a review from tfuxu September 5, 2023 14:33
Signed-off-by: Himadri Bhattacharjee <lavafroth@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Error when applying GTK-3 Theme.
1 participant