Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sync-server storage methods async #277

Closed
dbr opened this issue Jun 15, 2021 · 0 comments
Closed

Make sync-server storage methods async #277

dbr opened this issue Jun 15, 2021 · 0 comments
Labels
enhancement New feature or request sync-server TBD Pending reply or decision as to where it belongs.

Comments

@dbr
Copy link
Collaborator

dbr commented Jun 15, 2021

As discussed in #206

Currently the sync-server StorageTxn trait is all sync, which will mean the HTTP API will be blocked by any database IO

Since async trait methods aren't implemented in Rust (and aren't likely to be soon - based on rust-lang/rust#62149 "Async trait methods" they are dependent on rust-lang/rust#44265 which is still in progress), simplest solution is to use this crate:

https://github.com/dtolnay/async-trait

This would probably tie in with creating a more high-performance storage backend option like Postgres

@dbr dbr added enhancement New feature or request sync-server labels Jun 15, 2021
@djmitche djmitche added the TBD Pending reply or decision as to where it belongs. label Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request sync-server TBD Pending reply or decision as to where it belongs.
Projects
None yet
Development

No branches or pull requests

2 participants