Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story Preview should save story first #1072

Closed
swissspidy opened this issue Apr 6, 2020 · 5 comments · Fixed by #1122
Closed

Story Preview should save story first #1072

swissspidy opened this issue Apr 6, 2020 · 5 comments · Fixed by #1122
Assignees
Labels
P0 Critical, drop everything Type: Enhancement New feature or improvement of an existing feature

Comments

@swissspidy
Copy link
Collaborator

Feature Description

If a create a new story with a lot of elements and click on "Preview", I want to see my new story on the frontend right away, without having to first save the story.

Right now, if you preview a new story without saving it first, you'll get a 404 on the frontend.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

QA Instructions

@swissspidy swissspidy added the Type: Enhancement New feature or improvement of an existing feature label Apr 6, 2020
@jauyong
Copy link

jauyong commented Apr 7, 2020

@swissspidy @pbakaus should we just add this to the #221 when we work on auto-save in the future? Technically there is a workaround by manually pressing save so not a p0 and we can handle this later? So I'll make this a p1 but should I merge with 221 or keep this separate?

@jauyong jauyong added the P1 High priority, must do soon label Apr 7, 2020
@swissspidy
Copy link
Collaborator Author

P1 makes sense.

I'd keep this separate from #221 as it might not be a small task to implement this (from experience with Gutenberg). #221 is big enough as it is already.

@pbakaus
Copy link
Contributor

pbakaus commented Apr 7, 2020

yep agree with @swissspidy

@jauyong jauyong removed their assignment Apr 8, 2020
@pbakaus pbakaus added P0 Critical, drop everything and removed P1 High priority, must do soon labels Apr 9, 2020
@pbakaus
Copy link
Contributor

pbakaus commented Apr 9, 2020

Actually, I've changed my mind. This has come up too many times in the fish food for it to be a P1. We need to nip this in the bud ASAP. I've asked @dvoytenko to take a look, but let me know if there's a better person to look at this @swissspidy.

@swissspidy
Copy link
Collaborator Author

@pbakaus pbakaus added this to the 1.0 Alpha milestone Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 Critical, drop everything Type: Enhancement New feature or improvement of an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants