Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for mypy #79

Open
defreng opened this issue Dec 17, 2023 · 3 comments
Open

Add support for mypy #79

defreng opened this issue Dec 17, 2023 · 3 comments

Comments

@defreng
Copy link

defreng commented Dec 17, 2023

The package currently seems to miss the py.typed marker to indicate support for mypy

external/terraform.py:5: error: Skipping analyzing "tftest": module is installed, but missing library stubs or py.typed marker  [import-untyped]
external/terraform.py:5: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
@ludoo
Copy link
Collaborator

ludoo commented Dec 17, 2023

Why would that be something we need? :) I'm not interested in adding types to tftest...

@defreng
Copy link
Author

defreng commented Dec 17, 2023

Hey @ludoo

it's helpful even if you don't have types in this library... I.e. if I use mypy in my application which uses tftest, mypy could catch if I'm calling non-existing methods or methods with incorrect arguments on the TerraformTest class

also out of curiosity, why wouldn't you want to add types? :-)

@ludoo
Copy link
Collaborator

ludoo commented Dec 17, 2023

Thans. Would you care to send a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants