Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ha.pool.sks-keyservers.net no longer resolveable #6440

Closed
m-strzelczyk opened this issue Jul 19, 2021 · 6 comments
Closed

ha.pool.sks-keyservers.net no longer resolveable #6440

m-strzelczyk opened this issue Jul 19, 2021 · 6 comments
Assignees
Labels
samples Issues that are directly related to samples. type: process A process-related concern. May include testing, release, or the like.

Comments

@m-strzelczyk
Copy link
Contributor

Since this repo uses similar kokoro setup to the one python-compute uses, I figured it will face similar problems as described in googleapis/python-compute#79

I am working on a fix for this, so we don't use the unavailable key server.

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jul 19, 2021
@m-strzelczyk m-strzelczyk self-assigned this Jul 19, 2021
@busunkim96
Copy link
Contributor

@parthea

@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Jul 20, 2021
@busunkim96 busunkim96 added type: process A process-related concern. May include testing, release, or the like. and removed triage me I really want to be triaged. labels Jul 20, 2021
@parthea
Copy link
Collaborator

parthea commented Jul 21, 2021

Hi @m-strzelczyk ,
We're not seeing the issue in this repo, possible because there is no docs-presubmit check.

@m-strzelczyk
Copy link
Contributor Author

I know there's no docs-presubmit, but then there is the whole docker folder that uses fetch_gpg_keys.sh - how does this not break tests for the python-docs-samples? Is this just dead code, no longer used?

@parthea
Copy link
Collaborator

parthea commented Jul 23, 2021

Great question, @m-strzelczyk. It looks like the docker folder is being used in the pipeline checks. I'm not sure why fetch_gpg_keys.sh is not failing. I'll try it locally.

@parthea
Copy link
Collaborator

parthea commented Jul 23, 2021

I can reproduce the failure locally. We don't see the problem in the pipeline. It's likely because there is no docs-presubmit check.

@dandhlee
Copy link
Collaborator

dandhlee commented Aug 9, 2021

Closing this issue as the PR to fix it was closed, please reopen as needed!

@dandhlee dandhlee closed this as completed Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants