Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move samples to client library repositories #3891

Closed
29 of 40 tasks
busunkim96 opened this issue May 28, 2020 · 10 comments
Closed
29 of 40 tasks

Move samples to client library repositories #3891

busunkim96 opened this issue May 28, 2020 · 10 comments
Assignees
Labels
type: process A process-related concern. May include testing, release, or the like.

Comments

@busunkim96 busunkim96 added the type: process A process-related concern. May include testing, release, or the like. label May 28, 2020
@meredithslota
Copy link
Contributor

Is this list current?

@dandhlee
Copy link
Collaborator

Current as of today.

@anguillanneuf
Copy link
Member

anguillanneuf commented Jun 30, 2022

Missing pubsublite in the list. The samples in pubsub/ and pubsublite/ are x-product samples and don't belong with libraries.

@dandhlee
Copy link
Collaborator

@anguillanneuf would you like to migrate them back to this repo then?

@anguillanneuf
Copy link
Member

anguillanneuf commented Jun 30, 2022

@dandhlee everything here looks good. I was just pointing out the fact that the samples in this repo are x-product for my product area. Nothing needs to be changed.

@dandhlee
Copy link
Collaborator

Ah, misread that. So we should take out Pubsub from this list then right?

@anguillanneuf
Copy link
Member

I think you should check it off. We moved single-product Pub/Sub samples out of there a long time ago. AFAIK, the work is done :)

@anguillanneuf
Copy link
Member

I checked it off just now.

@dandhlee
Copy link
Collaborator

Thank you!

@leahecole
Copy link
Collaborator

I think this is obsolete now 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

No branches or pull requests

6 participants