Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Onboard USA names dataset #96

Merged
merged 9 commits into from Jul 21, 2021
Merged

feat: Onboard USA names dataset #96

merged 9 commits into from Jul 21, 2021

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Jun 17, 2021

Description

Onboard the USA names dataset

Checklist

Note: Delete items below that aren't applicable to your pull request.

  • Please merge this PR for me once it is approved.
  • If this PR adds or edits a dataset or pipeline, it was reviewed and approved by the Google Cloud Public Datasets team beforehand.
  • If this PR adds or edits a dataset or pipeline, I put all my code inside datasets/<YOUR-DATASET> and nothing outside of that directory.
  • This PR is appropriately labeled.

@adlersantos adlersantos added the data onboarding Onboard a dataset or submit a pipeline label Jun 17, 2021
@google-cla google-cla bot added the cla: yes label Jul 21, 2021
@adlersantos adlersantos marked this pull request as ready for review July 21, 2021 20:26
@adlersantos adlersantos changed the title feat: create usa_names dataset and pipeline feat: Onboard USA names dataset Jul 21, 2021
@leahecole leahecole merged commit eb28f0f into main Jul 21, 2021
@leahecole leahecole deleted the tswast-usa_names branch July 21, 2021 20:56
@tswast
Copy link
Contributor Author

tswast commented Jul 21, 2021

Thanks @leahecole and @adlersantos for seeing this PR to the end!

@adlersantos
Copy link
Member

Thanks for collaborating @tswast! Let's do this again sometime 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes data onboarding Onboard a dataset or submit a pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants