Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow DAG deploys without variables.json #91

Merged
merged 5 commits into from Jun 17, 2021
Merged

fix: Allow DAG deploys without variables.json #91

merged 5 commits into from Jun 17, 2021

Conversation

adlersantos
Copy link
Member

@adlersantos adlersantos commented Jun 16, 2021 •
edited

Description

Fixes #16, where some datasets don’t need custom variables to be onboarded.

Checklist

Note: Delete items below that aren't applicable to your pull request.

  • Please merge this PR for me once it is approved.
  • If this PR adds or edits a feature, I have updated the README accordingly.
  • This PR is appropriately labeled.

@adlersantos adlersantos added bug Something isn't working or open a bugfix cleanup Cleanup or refactor code labels Jun 16, 2021
@adlersantos adlersantos changed the title Allow DAG deploys without variables.json fix: Allow DAG deploys without variables.json Jun 16, 2021
@leahecole leahecole merged commit 8eaaae9 into main Jun 17, 2021
@leahecole leahecole deleted the fix-16 branch June 17, 2021 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leahecole leahecole leahecole approved these changes

Assignees
No one assigned
Labels
bug Something isn't working or open a bugfix cleanup Cleanup or refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Datasets without variables.json should still deploy properly
2 participants
@adlersantos @leahecole