Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix BigQuery dataset descriptions for covid19_tracking and ml_datasets #83

Merged
merged 2 commits into from Jun 15, 2021
Merged

fix: Fix BigQuery dataset descriptions for covid19_tracking and ml_datasets #83

merged 2 commits into from Jun 15, 2021

Conversation

adlersantos
Copy link
Member

@adlersantos adlersantos commented Jun 11, 2021 •
edited

Description

Because #61 allows BQ dataset descriptions to now be generated. I reran and revised the BQ dataset descriptions for covid19_tracking and ml_datasets.

Checklist

  • Please merge this PR for me once it is approved.
  • This PR is appropriately labeled.

@adlersantos adlersantos added bug Something isn't working or open a bugfix cleanup Cleanup or refactor code labels Jun 11, 2021
leahecole
leahecole reviewed Jun 14, 2021
View reviewed changes
Copy link
Contributor

@leahecole leahecole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Covid one looks good and makes sense but I worry we're losing the info with the penguins one - I went through all of the files and didn't see a description at all - is that right?

@adlersantos
Copy link
Member Author

Covid one looks good and makes sense but I worry we're losing the info with the penguins one - I went through all of the files and didn't see a description at all - is that right?

Yup that's expected. I removed the description because it talks about penguin measurements, which is meant for the penguins table, and not the ml_datasets BQ dataset (where it currently is).

@leahecole leahecole merged commit b5b7640 into main Jun 15, 2021
@leahecole leahecole deleted the fix-descriptions branch June 15, 2021 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leahecole leahecole leahecole approved these changes

Assignees
No one assigned
Labels
bug Something isn't working or open a bugfix cleanup Cleanup or refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adlersantos @leahecole