Fix: Terraform resource names can't start with digits, but BQ tables can #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leahecole
reviewed
Jun 8, 2021
| # Terraform resource names cannot start with digits, but BigQuery allows | ||
| # table names that start with digits. We prepend `bqt_` to table names | ||
| # that doesn't comply with Terraform's naming rule. | ||
| if resource["table_id"][0].isdigit(): |
leahecole
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Terraform resource names cannot start with digits, but BigQuery allows table names that start with digits. This means that upon
terraform apply, Terraform will error out despite the BQ table name being valid for Google Cloud.This PR prepends
bqt_to Terraform resource names for BigQuery tables that start with digits. If you have a BQ table that's named like311_austin, then the following Terraform resource will be generated:and will now be valid upon
terraform applyChecklist