Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Set location field as required for GCS buckets #224

Merged
merged 1 commit into from Nov 4, 2021
Merged

fix: Set location field as required for GCS buckets #224

merged 1 commit into from Nov 4, 2021

Conversation

adlersantos
Copy link
Member

@adlersantos adlersantos commented Nov 4, 2021 •
edited

Description

The latest release from Terraform's Google provider changed the location field for GCS buckets to be required. This leads to failing unit tests for all PRs. This PR should unblock that.

Checklist

  • Please merge this PR for me once it is approved.
  • This PR is appropriately labeled.

@adlersantos adlersantos added the bug Something isn't working or open a bugfix label Nov 4, 2021
@google-cla google-cla bot added the cla: yes label Nov 4, 2021
@adlersantos adlersantos merged commit bd8a3db into main Nov 4, 2021
@adlersantos adlersantos deleted the gcs-bucket-location-required branch November 4, 2021 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leahecole leahecole leahecole approved these changes

Assignees
No one assigned
Labels
bug Something isn't working or open a bugfix cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adlersantos @leahecole