Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Onboard: FDA food dataset #223

Merged
merged 7 commits into from Dec 8, 2021
Merged

Onboard: FDA food dataset #223

merged 7 commits into from Dec 8, 2021

Conversation

nlarge-google
Copy link
Collaborator

@nlarge-google nlarge-google commented Nov 3, 2021 •
edited

Description

Includes:
fda_food.food_enforcement,
fda_food.food_events

Checklist

Note: Delete items below that aren't applicable to your pull request.

  • Please merge this PR for me once it is approved.
  • If this PR adds or edits a dataset or pipeline, it was reviewed and approved by the Google Cloud Public Datasets team beforehand.
  • If this PR adds or edits a dataset or pipeline, I put all my code inside datasets/fda_food and nothing outside of that directory.
  • This PR is appropriately labeled.

@google-cla google-cla bot added the cla: yes label Nov 3, 2021
@nlarge-google nlarge-google reopened this Nov 5, 2021
@nlarge-google
Copy link
Collaborator Author

@adlersantos Please review this codse at your earliest convenience. Thanks!

adlersantos
adlersantos requested changes Nov 5, 2021
View reviewed changes
Copy link
Member

@adlersantos adlersantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR uses too many images. Try reducing them, or using a single one for pipelines and transforms that have much in common.

@nlarge-google
Copy link
Collaborator Author

@adlersantos I have merged FDA into one dataset. Please review. Thanks!

adlersantos
adlersantos approved these changes Dec 8, 2021
View reviewed changes
Copy link
Member

@adlersantos adlersantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@adlersantos adlersantos merged commit f0ced96 into GoogleCloudPlatform:main Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adlersantos adlersantos adlersantos approved these changes

Assignees

@adlersantos adlersantos

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nlarge-google @adlersantos