Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Combine san_francisco_bikeshare_* folders into san_francisco_bikeshare #211

Merged
merged 1 commit into from Oct 14, 2021

Conversation

adlersantos
Copy link
Member

@adlersantos adlersantos commented Oct 14, 2021

Description

This PR prevents creating new datasets called san_francisco_bikeshare_stations and san_francisco_bikeshare_status that don't exist on prod.

The proper dataset name for the SF bikeshare dataset is san_francisco_bikeshare, with two pipelines (BQ tables) under it:

datasets
    /san_francisco_bikeshare
        /bikeshare_station_info/*
        /bikeshare_station_status/*

Checklist

  • Please merge this PR for me once it is approved.
  • If this PR adds or edits a dataset or pipeline, it was reviewed and approved by the Google Cloud Public Datasets team beforehand.
  • If this PR adds or edits a dataset or pipeline, I put all my code inside datasets/san_francisco_311_* and nothing outside of those directories.
  • This PR is appropriately labeled.

@google-cla google-cla bot added the cla: yes label Oct 14, 2021
@adlersantos adlersantos added bug Something isn't working or open a bugfix data onboarding Onboard a dataset or submit a pipeline labels Oct 14, 2021
@leahecole leahecole merged commit 50e4e6d into main Oct 14, 2021
@leahecole leahecole deleted the sf-bikeshare-move branch October 14, 2021 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working or open a bugfix cla: yes data onboarding Onboard a dataset or submit a pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants