Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Delete temp GCS objects generated by gsutil's parallel composite upload for geos_fp dataset #195

Merged
merged 3 commits into from Sep 24, 2021
Merged

fix: Delete temp GCS objects generated by gsutil's parallel composite upload for geos_fp dataset #195

merged 3 commits into from Sep 24, 2021

Conversation

adlersantos
Copy link
Member

@adlersantos adlersantos commented Sep 23, 2021 •
edited

Description

  • Temporary GCS objects generated by gsutil's parallel composite for geos_fp dataset. Those must be manually deleted as recommended here
  • Add node pool affinities for KPod operators for geos_fp dataset

Checklist

Note: Delete items below that aren't applicable to your pull request.

  • Please merge this PR for me once it is approved.
  • If this PR adds or edits a dataset or pipeline, it was reviewed and approved by the Google Cloud Public Datasets team beforehand.
  • If this PR adds or edits a dataset or pipeline, I put all my code inside datasets/<YOUR-DATASET> and nothing outside of that directory.
  • This PR is appropriately labeled.

@google-cla google-cla bot added the cla: yes label Sep 23, 2021
@adlersantos adlersantos added bug Something isn't working or open a bugfix and removed cla: yes labels Sep 23, 2021
@google-cla google-cla bot added the cla: yes label Sep 23, 2021
@adlersantos adlersantos changed the title fix: Delete temporary GCS objects generated by gsutil's parallel composite upload for geos_fp dataset fix: Delete temp GCS objects generated by gsutil's parallel composite upload for geos_fp dataset Sep 23, 2021
shanecglass
shanecglass approved these changes Sep 24, 2021
View reviewed changes
Copy link
Contributor

@shanecglass shanecglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shanecglass shanecglass merged commit f307cce into main Sep 24, 2021
@shanecglass shanecglass deleted the geos-fp-cleanup branch September 24, 2021 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanecglass shanecglass shanecglass approved these changes

Assignees
No one assigned
Labels
bug Something isn't working or open a bugfix cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adlersantos @shanecglass