Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Onboard Iowa Liquor Sales dataset #193

Merged
merged 8 commits into from Oct 13, 2021

Conversation

vasuc-google
Copy link
Contributor

@vasuc-google vasuc-google commented Sep 23, 2021

Description

Based on #

Note: It's recommended to open an issue first for context and discussion.

Checklist

Note: Delete items below that aren't applicable to your pull request.

  • Please merge this PR for me once it is approved.
  • If this PR adds or edits a dataset or pipeline, it was reviewed and approved by the Google Cloud Public Datasets team beforehand.
  • If this PR adds or edits a dataset or pipeline, I put all my code inside datasets/iowa-liquor-sales and nothing outside of that directory.
  • This PR is appropriately labeled.

@google-cla google-cla bot added the cla: yes label Sep 23, 2021
@dipannitab2392 dipannitab2392 added the data onboarding Onboard a dataset or submit a pipeline label Sep 23, 2021
# limitations under the License.

# The base image for this build
# FROM gcr.io/google.com/cloudsdktool/cloud-sdk:slim
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra commented line

Copy link
Member

@adlersantos adlersantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will merge once the DAG run is successful.

@adlersantos adlersantos merged commit 06848c8 into GoogleCloudPlatform:main Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes data onboarding Onboard a dataset or submit a pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants