Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Onboard San Francisco Bikeshare Status #192

Merged
merged 5 commits into from Oct 13, 2021
Merged

feat: Onboard San Francisco Bikeshare Status #192

merged 5 commits into from Oct 13, 2021

Conversation

nlarge-google
Copy link
Collaborator

@nlarge-google nlarge-google commented Sep 22, 2021

Checklist

Note: Delete items below that aren't applicable to your pull request.

  • Please merge this PR for me once it is approved.
  • If this PR adds or edits a dataset or pipeline, it was reviewed and approved by the Google Cloud Public Datasets team beforehand.
  • If this PR adds or edits a dataset or pipeline, I put all my code inside datasets/san_francisco_bikeshare_status and nothing outside of that directory.
  • This PR is appropriately labeled.

@google-cla google-cla bot added the cla: yes label Sep 22, 2021
@nlarge-google
Copy link
Collaborator Author

@adlersantos I implemented chunksize in this PR. Could you please review? Thanks.

Copy link
Member

@adlersantos adlersantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's find time to refactor sometime this Q4

Comment on lines +15 to +20
dataset:
# The `dataset` block includes properties for your dataset that will be shown
# to users of your data on the Google Cloud website.

# Must be exactly the same name as the folder name your dataset.yaml is in.
name: san_francisco_bikeshare_status
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See if you can merge these pipelines into a single datasets/san_francisco folder

@adlersantos adlersantos merged commit e4e1f26 into GoogleCloudPlatform:main Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants