New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Onboard San francisco film locations #190
Merged
adlersantos
merged 5 commits into
GoogleCloudPlatform:main
from
nlarge-google:san-francisco-film-locations
Oct 13, 2021
Merged
feat: Onboard San francisco film locations #190
adlersantos
merged 5 commits into
GoogleCloudPlatform:main
from
nlarge-google:san-francisco-film-locations
Oct 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlarge-google
changed the title
San francisco film locations
Feat: Onboard San francisco film locations
Sep 21, 2021
nlarge-google
changed the title
Feat: Onboard San francisco film locations
feat: Onboard San francisco film locations
Sep 21, 2021
adlersantos
requested changes
Oct 13, 2021
# limitations under the License. | ||
|
||
# The base image for this build | ||
# FROM gcr.io/google.com/cloudsdktool/cloud-sdk:slim |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra commented line
datasets/san_francisco_film_locations/_images/run_csv_transform_kub/csv_transform.py
Outdated
Show resolved
Hide resolved
datasets/san_francisco_film_locations/_images/run_csv_transform_kub/csv_transform.py
Outdated
Show resolved
Hide resolved
Comment on lines
+39
to
+41
|
||
args: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra blank lines
adlersantos
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Note: Delete items below that aren't applicable to your pull request.
datasets/san_francisco_film_locations
and nothing outside of that directory.