Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Onboard sunroof dataset #166

Merged
merged 6 commits into from Oct 28, 2021
Merged

feat: Onboard sunroof dataset #166

merged 6 commits into from Oct 28, 2021

Conversation

nlarge-google
Copy link
Collaborator

@nlarge-google nlarge-google commented Sep 2, 2021

Checklist

Note: Delete items below that aren't applicable to your pull request.

  • Please merge this PR for me once it is approved.
  • If this PR adds or edits a dataset or pipeline, it was reviewed and approved by the Google Cloud Public Datasets team beforehand.
  • If this PR adds or edits a dataset or pipeline, I put all my code inside datasets/sunroof> and nothing outside of that directory.
  • This PR is appropriately labeled.

@google-cla google-cla bot added the cla: yes label Sep 2, 2021
Copy link
Member

@adlersantos adlersantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge the images into one, and some minor things. And we should be good to go!

@nlarge-google
Copy link
Collaborator Author

@adlersantos I reworked this to use just one image and implemented chunking as well. Please recheck. Thanks!

@nlarge-google
Copy link
Collaborator Author

@adlersantos Changes have been made. Please review at your earliest convenience. Thanks!

@adlersantos adlersantos self-requested a review October 21, 2021 20:28
Copy link
Member

@adlersantos adlersantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the node pool affinity and we should be good

@nlarge-google
Copy link
Collaborator Author

@adlersantos Made the change you asked for. Please review and confirm. Thanks! Nick.

@adlersantos adlersantos merged commit 375cbae into GoogleCloudPlatform:main Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants