Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Onboard IRS 990 dataset #150

Merged
merged 4 commits into from Aug 27, 2021
Merged

feat: Onboard IRS 990 dataset #150

merged 4 commits into from Aug 27, 2021

Conversation

dipannitab2392
Copy link
Contributor

@dipannitab2392 dipannitab2392 commented Aug 26, 2021 •
edited by adlersantos

Description

Onboards the IRS 990 dataset

Note: It's recommended to open an issue first for context and discussion.

Checklist

Note: Delete items below that aren't applicable to your pull request.

  • Please merge this PR for me once it is approved.
  • If this PR adds or edits a dataset or pipeline, it was reviewed and approved by the Google Cloud Public Datasets team beforehand.
  • If this PR adds or edits a dataset or pipeline, I put all my code inside datasets/irs_990 and nothing outside of that directory.
  • This PR is appropriately labeled.

@google-cla google-cla bot added the cla: yes label Aug 26, 2021
@adlersantos adlersantos self-requested a review August 26, 2021 15:58
@adlersantos adlersantos added the data onboarding Onboard a dataset or submit a pipeline label Aug 26, 2021
adlersantos
adlersantos requested changes Aug 26, 2021
View reviewed changes
Copy link
Member

@adlersantos adlersantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please regenerate the Terraform files using the generate_terraform.py script, so the BQ descriptions in the .tf files match what's in YAML files.

datasets/irs_990/irs_990_2014/pipeline.yaml Show resolved Hide resolved
datasets/irs_990/irs_990_2015/pipeline.yaml Show resolved Hide resolved
datasets/irs_990/irs_990_2016/pipeline.yaml Show resolved Hide resolved
@adlersantos adlersantos merged commit 1105eed into GoogleCloudPlatform:main Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adlersantos adlersantos adlersantos approved these changes

Assignees
No one assigned
Labels
cla: yes data onboarding Onboard a dataset or submit a pipeline
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dipannitab2392 @adlersantos