Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: shared_variables.json should not be reset when deploying #147

Merged
merged 1 commit into from Aug 26, 2021
Merged

fix: shared_variables.json should not be reset when deploying #147

merged 1 commit into from Aug 26, 2021

Conversation

adlersantos
Copy link
Member

@adlersantos adlersantos commented Aug 23, 2021 •
edited

Description

The shared_variables.json file introduced by #122 gets reset to an empty JSON object during a deploy. This PR fixes that.

Checklist

  • Please merge this PR for me once it is approved.
  • This PR is appropriately labeled.

@adlersantos adlersantos added the bug Something isn't working or open a bugfix label Aug 23, 2021
@google-cla google-cla bot added the cla: yes label Aug 23, 2021
@adlersantos adlersantos merged commit a6754df into main Aug 26, 2021
@adlersantos adlersantos deleted the fix-shared-vars branch August 26, 2021 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leahecole leahecole leahecole approved these changes

Assignees
No one assigned
Labels
bug Something isn't working or open a bugfix cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adlersantos @leahecole